The website uses cookies. By using this site, you agree to our use of cookies as described in the Privacy Policy.
I Agree
blank_error__heading
blank_error__body
Text direction?

bump up the default runtime to "io.containerd.runc.v2" by AkihiroSuda · Pull Request #1359 · containerd/cri

Conversation

Copy link
Member

The former default runtime "io.containerd.runc.v1" won't support new features
like support for cgroup v2: containerd/containerd#3726

Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp

Copy link
Member Author

/test pull-cri-containerd-windows-cri

Copy link
Member Author

/test pull-cri-containerd-node-e2e

Copy link
Member

mikebrow left a comment

see comments...

docs/config.md Show resolved Hide resolved
docs/config.md Show resolved Hide resolved
Copy link
Member

@jterry75 @Random-Liu thoughts on PRs that hit _unix isms. As a general rule, should we try to shadow/pair another PR to do the windows equivalent changes or make suggestions for the windows equivalent in the PR if amenable/doable.

Copy link
Member

We need to make sure the Docker and containerd packages on OS distributions contain the new shim binary.

Copy link
Member

We need to make sure the Docker and containerd packages on OS distributions contain the new shim binary.

Would be nice if we had an official line of communication for the distributions, where we could get feedback / verification.

Copy link
Member Author

I think we can just mention that in v1.4 release note.

Copy link
Member Author

@mikebrow Windows stuff is unrelated to this PR. Windows doesn't use io.containerd.runc.v%d.

Copy link
Member

mikebrow commented Dec 13, 2019
edited

@mikebrow Windows stuff is unrelated to this PR. Windows doesn't use io.containerd.runc.v%d.

ok removed that comment.. will address the windows config docs elsewhere.

Copy link
Member

I think we can just mention that in v1.4 release note.

true...still would be nice to give them a heads up if they are not watching master changes.

Copy link
Member

mikebrow left a comment

LGTM

just nits on the docs can handle them in a followup

The former default runtime "io.containerd.runc.v1" won't support new features
like support for cgroup v2: containerd/containerd#3726

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Copy link
Member Author

updated docs

Copy link
Member Author

AkihiroSuda commented Dec 16, 2019
edited

We need to make sure the Docker and containerd packages on OS distributions contain the new shim binary.

cc @thaJeztah Who is maintaining Docker containerd.io package?

Copy link
Member

mikebrow left a comment

LGTM

Copy link
Contributor

cc @thaJeztah Who is maintaining Docker containerd.io package?

I can have a look at that one; plan was to open-source the repo soon (think there's one remaining PR for that)

@@ -298,7 +298,7 @@ func (c *criService) cleanupSandboxFiles(id string, config *runtime.PodSandboxCo
func (c *criService) taskOpts(runtimeType string) []containerd.NewTaskOpts {
// TODO(random-liu): Remove this after shim v1 is deprecated.
var taskOpts []containerd.NewTaskOpts
if c.config.NoPivot && runtimeType == plugin.RuntimeRuncV1 {
if c.config.NoPivot && (runtimeType == plugin.RuntimeRuncV1||runtimeType==plugin.RuntimeRuncV2) {

This comment has been minimized.

Random-Liu Dec 17, 2019
Member

We may want to cherry-pick this part into 1.3.

This comment has been minimized.

Copy link
Member

/lgtm

Random-Liu merged commit ff8a2e7 into containerd:master Dec 17, 2019
6 checks passed
6 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pull-cri-containerd-build Job succeeded.
Details
pull-cri-containerd-node-e2e Job succeeded.
Details
pull-cri-containerd-verify Job succeeded.
Details
pull-cri-containerd-windows-cri Job succeeded.
Details
AkihiroSuda added a commit to AkihiroSuda/cri-containerd that referenced this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
Measure
Measure
Related Notes
Get a free MyMarkup account to save this article and view it later on any device.
Create account

End User License Agreement

Summary | 2 Annotations
won't support new features
2020/07/27 09:24
like support for cgroup v2
2020/07/27 09:24