Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroupv2 support meta issue #2315

Open
kolyshkin opened this issue Apr 15, 2020 · 6 comments
Open

cgroupv2 support meta issue #2315

kolyshkin opened this issue Apr 15, 2020 · 6 comments
Labels

Comments

@kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Apr 15, 2020

This is a list of cgroupv2 issues and PRs needed to make cgroupv2 a first-class citizen in runc. This is in addition to #2209.

Issue description Bugfix PR Status
add integration tests #2295 🟢 merged
use "max" for negative values #2272, #2300 🟢 merged
don't try to set kmem for systemd case #2270 🟢 merged
fix setting MemorySwap #2288 🟢 merged
fix fs2 driver initialization #2299 🟢 merged
#2298 fs2 driver does not work with default cgroups path #2305 🟢 merged
#2287 runc --systemd-cgroup update does not update systemd scope #2343 🟢 merged
refactor (remove v1 Paths from v2 code) #2282, #2299, #2386, #2411 🟡 WIP
#2351 port events to v2 #2352 🟢 merged
#2328 checkpoint of cgroup2 fs is not working #2335 🟢 merged
#2313 runc --systemd-cgroup run: need to check that StartTransientUnit succeeds
#2309 Check the error return from StopUnit() in UnifiedManager#Destroy()
#2331 🟢
#2163 support rootless systemd #2281 🟢 merged
#2316 eBPF failure on s390x #2381 🟢 merged
#2339 rootless: "open /sys/fs/cgroup/cgroup.subtree_control: permission denied"": unknown #2340 🟢 merged
#2356 nest: move PID 1 process to non-initial cgroup? #2416 🟢 merged
#2367 nest: revert "CreateCgroupPath: only enable needed controllers"? #2395 🟢 merged
#2366 support updating devices N/A 🔴
#2403 nest: Manager.Destroy() should recursively delete subgroups #2412 🟢 merged
@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Apr 15, 2020

force use of systemd driver if system runs systemd

I'm not sure runc should force this, though Moby/Podman/containerd/CRI-O may force it.

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Apr 21, 2020

@kolyshkin Can we remove "force use of systemd driver if system runs systemd" ?

@kolyshkin
Copy link
Contributor Author

@kolyshkin kolyshkin commented Apr 25, 2020

Can we remove "force use of systemd driver if system runs systemd" ?

done

I think there's something that needs to be done here, but I'm not yet quite sure what. Maybe if systemd is running but is not used by runc, runc should check that the cgroup path we're operating on is not managed by systemd (i.e. this cgroup or its parents were not created by systemd).

Anyway, I need to think more about it. Removed for now.

@Werkov
Copy link

@Werkov Werkov commented Apr 26, 2020

The systemd compatible way to use cgroupfs directly is if runc operates in a delegated cgroup.

@giuseppe
Copy link
Contributor

@giuseppe giuseppe commented May 6, 2020

GetOwnCgroup is currently not supported for cgroup v2. Do I open a new issue to track it?

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented May 8, 2020

Yes please @giuseppe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.